Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should diffdf care about data frame class #42

Open
kieranjmartin opened this issue Oct 23, 2019 · 2 comments
Open

Should diffdf care about data frame class #42

kieranjmartin opened this issue Oct 23, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kieranjmartin
Copy link
Collaborator

Right now diffdf doesn't care if one object it compares is a tibble and one is a data.table, as they are both data.frames. I'm thinking it probably should? At least generate a message about it

@kieranjmartin kieranjmartin added the enhancement New feature or request label Oct 23, 2019
@gowerc
Copy link
Owner

gowerc commented Dec 10, 2019

So I think we should flag this but that by default it should just be done as a note.

We could add (yet another) option to raise this as a warning instead ?

@gowerc
Copy link
Owner

gowerc commented Dec 29, 2020

thinking about this some more I don't think we should check for this. Thinking from a QC perspective all we care about is that the contents have been derived correctly. Wether the user chose to use data.table or tibble or data.frame shouldn't really matter at all I don't think.

The current implementation in #67 prints the object type out in the summary but doesn't raise an error if they are different. I think I am happy with this implementation, let me know if you feel different @kieranjmartin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants