Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StreamPlayer#reset public #7

Closed
TonalidadeHidrica opened this issue Apr 29, 2019 · 4 comments
Closed

Make StreamPlayer#reset public #7

TonalidadeHidrica opened this issue Apr 29, 2019 · 4 comments
Labels
enhancement Feature Request Requesting a new feature help wanted question

Comments

@TonalidadeHidrica
Copy link
Contributor

I looked for a way to freeing the resources opened by the StreamPlayer and found StreamPlayer#reset method, but it was private and was not accessible from outside. Why is it private? Is it possible to make it public? (I also found that calling StreamPlayer#open method calls this reset method so it seems I don't have to worry so much as long as I used same StreamPlayer instance.)
@goxr3plus
Copy link
Owner

Calling the .stop() method will free up all the resources, have a look at it :)

@goxr3plus
Copy link
Owner

Please try. stop() and let me know :)

@TonalidadeHidrica
Copy link
Contributor Author

But stop() does not close file stream, audio output stream etc, right? It seems that the only way to close them is calling reset().

@goxr3plus
Copy link
Owner

Please check the latest release :) https://github.com/goxr3plus/java-stream-player/releases

9.0.1 solves exactly what you asked for :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature Request Requesting a new feature help wanted question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goxr3plus @TonalidadeHidrica