New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove `A.Cmd` #307

Closed

pellared opened this issue Nov 24, 2022 · 0 comments · Fixed by #308

Labels

Milestone

Member

pellared commented Nov 24, 2022 •

edited

Loading

The reasons to remove A.Cmd are the following:

~~os/exec is not hardened by default. More: Go blog: Command PATH security in Go~~
~~github.com/goyek/x/cmd covers most use cases. It can use golang.org/x/sys/execabs to be more secure.~~

Programs build using Go 1.19 has the fix in place. See https://pkg.go.dev/os/exec#hdr-Executables_in_the_current_directory and https://go.dev/blog/go1.19.

Reduce the API surface. Users can use their own helpers or github.com/goyek/x/cmd.

The text was updated successfully, but these errors were encountered:

pellared added the enhancement label

pellared added this to the v2 milestone

pellared mentioned this issue

Remove A.Cmd #308

Merged

5 tasks

pellared closed this as completed in #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment