[faad_dec] fail build

[sl1pkn07]

  CC faad_dec.c
In file included from faad_dec.c:40:0:
/usr/include/faad.h:32:9: note: #pragma message: please update faad2 include filename and function names!
 #pragma message("please update faad2 include filename and function names!")
         ^~~~~~~
In file included from /usr/include/faad.h:35:0,
                 from faad_dec.c:40:
faad_dec.c: In function 'FAAD_GetCodecName':
faad_dec.c:408:35: error: expected ';' before 'PACKAGE_VERSION'
  if (ctx->is_sbr) return "FAAD2 " FAAD2_VERSION " SBR mode";
                                   ^
faad_dec.c:409:18: error: expected ';' before 'PACKAGE_VERSION'
  return "FAAD2 " FAAD2_VERSION;
                  ^
make[2]: *** [../../config.mak:157: faad_dec.o] Error 1

gpac commit 83fc19f
gcc 7.2.0
ffmpeg 3.3.4
faad2 2.8.1

[aureliendavid]

Hello,

This seems to be a source bug in faad2 2.8.1. Here's a debian bug report about it: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868854

If you're using debian they fixed it the the faad2_2.8.1-2 package by applying this patch:

Description: Set the FAAD2_VERSION macro back to the version string.
 In the next upstream release this macro will read "unknown version" and an API
 will be provided to retrieve the actual library version at run-time.
Author: Fabian Greffrath <fabian@debian.org>

--- a/include/neaacdec.h
+++ b/include/neaacdec.h
@@ -73,7 +73,7 @@ extern "C" {
   #endif
 #endif
 
-#define FAAD2_VERSION PACKAGE_VERSION
+#define FAAD2_VERSION "2.8.1"

If you don't have access to that package you can patch your /usr/include/neaacdec.h directly.

Another temporary solution might be to define PACKAGE_VERSION from the gcc command line with something like ./configure --extra-cflags="-DPACKAGE_VERSION=\"2.8.1\""