Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package is not the production build #31

Closed
adampenn opened this issue Sep 4, 2020 · 4 comments
Closed

npm package is not the production build #31

adampenn opened this issue Sep 4, 2020 · 4 comments

Comments

@adampenn
Copy link

adampenn commented Sep 4, 2020

When doing a npm install of ngx-forms-typed I cannot use it in my angular app since it cant read the public api ts file. It seems like you published the dist folder of forms after you did a non production build. This seems to cause issues when importing your project. I did a test locally where I did a ng build forms --prod and published dist/forms to a local npm server i have. This resolved the issue. Can i request that you push a new prod build to npm? Please feel free to contact me with any questions

@gparlakov
Copy link
Owner

gparlakov commented Sep 5, 2020

Hi @adampenn, thanks for reaching out. I'll investigate and get back to you as soon as possible. Can you confirm you are using the @latest version 1.0.4 1.0.5?

@adampenn
Copy link
Author

adampenn commented Sep 5, 2020

Yes that is the version I am using

@gparlakov
Copy link
Owner

I was able to reproduce locally and @adampenn you are absolutely correct, thanks!

Released the 1.0.6 version and tested that it actually works :)

@adampenn
Copy link
Author

adampenn commented Sep 5, 2020

Thank you very much for your timely response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants