Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect README install instructions #52

Closed
Josh015 opened this issue Jul 6, 2021 · 3 comments · Fixed by #57
Closed

Incorrect README install instructions #52

Josh015 opened this issue Jul 6, 2021 · 3 comments · Fixed by #57

Comments

@Josh015
Copy link
Contributor

Josh015 commented Jul 6, 2021

In your README "Getting Started" section it says to use the command npm install --save-dev ngx-forms-typed, but the npm page sidebar says npm i ngx-forms-typed. I assume it's the latter, but you might want to get those in sync.

@gparlakov
Copy link
Owner

@Josh015 thanks for your feedback.

Why do you think these should be in sync?

@Josh015
Copy link
Contributor Author

Josh015 commented Jul 7, 2021

Well last I'd checked your package isn't a dev dependency, so its instructions should tell the user to install it like a regular dependency.

@gparlakov
Copy link
Owner

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants