This repository has been archived by the owner on Nov 17, 2017. It is now read-only.

"Page not found" hardcoded in NotFoundPage #70

Open

reymus opened this issue Jul 26, 2015 · 4 comments

Contributor

reymus commented Jul 26, 2015

The message "Page not found" is hardcoded in the NotFoundPage. Problem is easily reproducible by switching to French and clicking the "an unexisting photo" link in the footer.

reymus closed this as completed

Contributor Author

reymus commented Jul 26, 2015

Pull request: #71

reymus reopened this

Contributor

Wykks commented Jul 27, 2015

Well, to be consistent, the message in ErrorPage should be translated too.

Wykks mentioned this issue

Fix hardcoded messages (again) #72

Open

Owner

gpbl commented Jul 27, 2015

Thanks... there are other texts missing, yes: I actually meant to provide an example for i18n, not to translate all the things :-) otherwise the project get too complex to maintain.

Contributor

Wykks commented Jul 29, 2015

Yeah that's why I didn't done it first.This is just about consistency because having the NotFoundPage translated but not the ErrorPage isn't logical.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.