a11y: Set week number tabIndex to -1 if onWeekClick is not defined #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 645 645
Branches 141 141
=====================================
Hits 645 645
Continue to review full report at Codecov.
|
|
That’s great! Thank you. |
kimamula
pushed a commit
to kimamula/react-day-picker
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
showWeekNumbersprop is specified, whileonWeekClickis not defined, this means that the week numbers are only supposed to be rendered for their visual purpose, not to be interacted with. It seems like tabIndex is left at 0 regardless, which means you have to tab through them even though they cannot be interacted with.This PR sets tabIndex to -1 on the week numbers if
onWeekClickis not defined, so that the visually impaired won't have to cycle through the non-interactive elements.Tests, coverage and linting has run successfully.