Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release 1.4? #131

Closed
hansgru opened this issue Apr 6, 2014 · 10 comments
Closed

New Release 1.4? #131

hansgru opened this issue Apr 6, 2014 · 10 comments

Comments

@hansgru
Copy link

hansgru commented Apr 6, 2014

Any chance getting a new release ? e.g. 1.4 ?
Quite a few things seem to be fixed since 1.3.

@asoltesz
Copy link

asoltesz commented Sep 5, 2014

I second this motion, a new release would be absolutely needed.

The last release available on the Grails plugin portal is now more than 2 years old.

@ghost
Copy link

ghost commented Sep 5, 2014

I think everyone would like to see a new release ASAP, but we need to establish whether the current state of the plugin is "release ready". I'm not sure who is the best person to make that call (AFAIK this project doesn't really have a leader at the moment), perhaps either @robfletcher or @sbglasius.

All the tests are passing at the moment (when run locally), so there's no obvious reason why it couldn't be released now.

@bodiam
Copy link
Contributor

bodiam commented Sep 5, 2014

+1 on both your remarks. I'm still not sure how the build works, it hasn't been triggered since April, so apparently it doesn't build on commit. Maybe that's a thing to pickup, and maybe travis or drone can build the plugin?

@ghost
Copy link

ghost commented Sep 5, 2014

@bodiam oops, I didn't notice the date of the failing build, I ran the tests locally and they all pass (I've edited my comment above)

@robfletcher
Copy link
Contributor

I think the cloudbees build has probably stopped since the project has moved to a new org. I think there are probably better hosting options now anyway. Might be worth trying Travis or Drone.

I just had a quick look & the Cloudbees UI is not very clear about how to add a new build. It's also pretty painfully slow.

@bodiam
Copy link
Contributor

bodiam commented Sep 7, 2014

As part of this issue, I've replaced Cloudbees with Travis. The CLI tests don't run due to a security exeception, so these are disabled for now, and only the unit: test are running. Also updated the readme.md for this.

@bodiam
Copy link
Contributor

bodiam commented Sep 9, 2014

@robfletcher Rob, build is working nicely again, the tests are green thanks to @lhotari and supports a nice build matrix for 2.2, 2.3 and 2.4, so I'd like to make a new release this week. What do you think?

@robfletcher
Copy link
Contributor

@bodiam Great. Do it. I think the CLI tests don't work with more recent versions of Grails as support was dropped. Don't forget there are integration and functional tests under test/projects. The functional tests won't work on Travis as they are Geb browser based tests but the integration tests should.

@bodiam
Copy link
Contributor

bodiam commented Sep 10, 2014

@robfletcher Thanks for the tip. I'll run those tests manually. I tried to release the plugin (1.4), but I'm not authorized. I asked for permissions on the dev mailing list, so we'll have to wait on that. There are some pull requests open, but I don't mind making another release next week or so, either a 1.5 or a 1.4.1, depending on the featureset or bugfixes.

@bodiam
Copy link
Contributor

bodiam commented Sep 10, 2014

It's done for now. If there are any issues, let us know, and we'll fix them ASAP in the 1.4.1 version of the plugin. Thanks all for the hard work!!

@bodiam bodiam closed this as completed Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants