Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should make from-ucontext backtracing work correctly across most implementations #1526

Open
alk opened this issue Jun 12, 2024 · 0 comments

Comments

@alk
Copy link
Contributor

alk commented Jun 12, 2024

SUBJ. See #1524 and 7c73631

I.e. we currently do fixed number of frames skipping for a number of backtracing methods. Most notably libunwind, but also libgcc and pretty much everything else, except generic_fp. The latter knows how to use registers from ucontext to step from right place.

We should consider something like this. Full backtrace is collected, then ucontext's PC (via GetPC) is used to locate right location and then stack would be "cut" up to this place. It should be somewhat reliable (hopefully). It should replace the logic in cpu profiling handler that automagically adds PC from ucontext (and not necessarily correctly).

Good mini-project for someone to contribute IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant