-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashes on album creation (it seems) #262
Comments
The same thing happened to me as well -- I'm on Ubuntu 20.04. I'm uploading a large library. The code that I was running was the prebuilt binary from github as of Dec 31.
|
Please, provide same log with @pjsg Can you provide the version with |
This the tail end of the log -- I've removed a few characters from the pageToken just in case that gives access to my library Version (downloaded from github on Dec 31, 2020)
log
Somewhat to my surprise, it failed quite quickly -- within a few hours. The first run was probably after 5 days.... |
Can you run it disabling concurrency? Try add |
Failed again -- even quicker (log below). However, it turns out that DSCN4527.JPG is corrupt -- this is the ZIP of that image. It consists entirely of NULLs!
|
Thanks for the information @pjsg I'm on holidays right now but I will take a look afterwards. |
Hi! Enjoy your vacation @pacoorozco ! When you get back... :) I fixed the problem by checking if the MediaItem is nil, and if so returning an error instead of panicking... Some people might still want it to panic to fix the broken image: Or modify the code slightly to this: if res.MediaItem == nil {
return nil, fmt.Errorf("failed to create metadata: %s (%v)", res.Status.Message)
} |
Hi @Richard87 You found the bug... and as far as I was suspecting it's on the Your fix needs some refinement, because if there are several I don't understand why this |
It should be fixed on v2.0.1 |
Yup it was weird, it returned an array of mediaItems, but it was only 1 item when it crashed... Maybe because I have configured it to not create albums? Anyway, thanks for the quick fix! :) |
Describe the bug
I'm getting a crash during uploading quite a lot of pictures I took during the years with multiple phones
Desktop & Client versions (please complete the following information):
Additional context
Stack trace:
The text was updated successfully, but these errors were encountered: