Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested ButtonBoard? #607

Open
bennuttall opened this issue Nov 29, 2017 · 2 comments
Open

Nested ButtonBoard? #607

bennuttall opened this issue Nov 29, 2017 · 2 comments
Projects

Comments

@bennuttall
Copy link
Member

It's possible to nest LEDBoards within LEDBoards, but the same does not apply to ButtonBoard. If there's no reason this can't exist, we should add it, and include it in tests in #606.

@lurch
Copy link
Contributor

lurch commented Dec 1, 2017

Should be possible, I guess it'd just need to have all the isinstance related code that http://gpiozero.readthedocs.io/en/stable/_modules/gpiozero/boards.html#LEDCollection uses (except in this case it'd be using isinstance(pin_or_collection, ButtonBoard) instead of isinstance(pin_or_collection, LEDCollection) and Button instead of LEDClass).

Coincidentally I ordered myself a ScoreZero earlier today, so I'll see if I get time over the weekend to have a fiddle...

@lurch
Copy link
Contributor

lurch commented Dec 1, 2017

Hmmm, although it might need a bit of thinking about how events are hooked up, and whether changes in a sub-button-board also bubble up to the parent button-board...

@bennuttall bennuttall added this to Triage in Triage Feb 8, 2019
@bennuttall bennuttall moved this from Triage to Less important / ready in Triage Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Triage
  
Less important / ready
Development

No branches or pull requests

2 participants