Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gPodderShownotesText.text_view hardcodes white background, doesn't respect GTK theme #369

Closed
blaabjerg opened this issue Dec 21, 2017 · 1 comment
Assignees

Comments

@blaabjerg
Copy link

In src/gpodder/gtkui/shownotes.py line 125, the text_view background is hardcoded to white. This looks fine with a light GTK theme, but it looks bad with a dark theme.

It only affects the margin of the text view, so perhaps there is a way to query for the actual text bgcolor and use that instead?

@elelay
Copy link
Member

elelay commented Feb 15, 2018

It's ok since 3.10.0 with the text shownotes, but still an issue with webkit2 html shownotes.
I don't thing real html shownotes should be changed. Only textual shownotes displayed as html should be.
I'm working on a prototype using webkit user stylesheets.

@elelay elelay self-assigned this Feb 15, 2018
@elelay elelay closed this as completed in 444647b Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants