Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urgent - all PRs blocked because of failing tests #1122

Closed
TheoMcCabe opened this issue Apr 17, 2024 · 4 comments
Closed

Urgent - all PRs blocked because of failing tests #1122

TheoMcCabe opened this issue Apr 17, 2024 · 4 comments
Assignees
Labels
bug Something isn't working triage Interesting but stale issue. Will be close if inactive for 3 more days after label added.

Comments

@TheoMcCabe
Copy link
Collaborator

Tests run fine locally but fail on the build server. This is blocking my 2 prs and seeminly every other PR on the repo.

@ATheorell i feel like its to do with caching and API keys - would you be able to give us a quick fix?

Also @similato87 were you looking at removing the catching? do you know anything about why these are failing?

@TheoMcCabe TheoMcCabe added bug Something isn't working triage Interesting but stale issue. Will be close if inactive for 3 more days after label added. labels Apr 17, 2024
@ATheorell
Copy link
Collaborator

@TheoMcCabe caching is removed.

There is one test that uses an openai key and did so successfully on github for a while, though
stopped working recently. My suggestion is that we remove this test for now, until we have a working key. However, this means that we have to test manually that gpte runs locally before merging.

@ATheorell
Copy link
Collaborator

handled with hotfix in #1123

@TheoMcCabe
Copy link
Collaborator Author

Thanks for sorting @ATheorell . hero

@ATheorell
Copy link
Collaborator

No problem! I see this as a temporary fix though. We can keep the issue open for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Interesting but stale issue. Will be close if inactive for 3 more days after label added.
Projects
None yet
Development

No branches or pull requests

4 participants