Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer::add_attachment compares image view height with framebuffer layersCount #48

Closed
FibHeap opened this issue Oct 25, 2017 · 2 comments
Assignees

Comments

@FibHeap
Copy link

FibHeap commented Oct 25, 2017

For layered rendering one wants to attach a layered 2D image view to a layered framebuffer.
The base mipmap level of such an image view is W x H x 1. This dimensions is seems to be compared to W x H and layers of the framebuffer.

framebuffer.cpp:152

 if (view_size[0] < m_framebuffer_size[0] ||
     view_size[1] < m_framebuffer_size[1] ||
     view_size[2] < m_framebuffer_size[2])
 {
     /* Attachment size is wrong */
     anvil_assert_fail();

    goto end;
 }
@DominikWitczakAMD
Copy link
Contributor

Apologies, haven't gotten to this yet. I will address this in the coming update.

@DominikWitczakAMD DominikWitczakAMD self-assigned this Jan 24, 2018
@DominikWitczakAMD
Copy link
Contributor

A fix for this has been included in the recent update.

DominikWitczakAMD added a commit that referenced this issue Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants