Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

WSL needs to understand && and || #126

Closed
litherum opened this issue Oct 13, 2018 · 5 comments
Closed

WSL needs to understand && and || #126

litherum opened this issue Oct 13, 2018 · 5 comments

Comments

@litherum
Copy link
Contributor

Migrated from https://bugs.webkit.org/show_bug.cgi?id=177062:

At 2017-09-18T01:29:02Z, mmaxfield@apple.com wrote:
WSL needs to understand && and ||

@litherum
Copy link
Contributor Author

At 2017-09-18T01:30:10Z, mmaxfield@apple.com wrote:
Created attachment 321060
Patch

@litherum
Copy link
Contributor Author

At 2017-09-18T03:00:28Z, fpizlo@apple.com wrote:
Comment on attachment 321060
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321060&action=review

Tools/WebGPUShadingLanguageRI/Evaluator.js:175

  •    case "&&":
    

Nice. I like that you’re just using the operator itself.

@litherum
Copy link
Contributor Author

At 2017-09-18T03:39:23Z, commit-queue@webkit.org wrote:
Comment on attachment 321060
Patch

Clearing flags on attachment: 321060

Committed r222139: http://trac.webkit.org/changeset/222139

@litherum
Copy link
Contributor Author

At 2017-09-18T03:39:25Z, commit-queue@webkit.org wrote:
All reviewed patches have been landed. Closing bug.

@litherum
Copy link
Contributor Author

At 2017-09-27T19:29:29Z, webkit-bug-importer@group.apple.com wrote:
rdar://problem/34693373

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant