Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

WSL should support structs #157

Closed
litherum opened this issue Oct 14, 2018 · 4 comments
Closed

WSL should support structs #157

litherum opened this issue Oct 14, 2018 · 4 comments

Comments

@litherum
Copy link
Contributor

Migrated from https://bugs.webkit.org/show_bug.cgi?id=176290:

At 2017-09-03T03:44:19Z, fpizlo@apple.com wrote:
Patch forthcoming.

@litherum
Copy link
Contributor Author

At 2017-09-03T03:48:24Z, fpizlo@apple.com wrote:
Created attachment 319756
the patch

@litherum
Copy link
Contributor Author

At 2017-09-03T04:18:05Z, fpizlo@apple.com wrote:
Comment on attachment 319756
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319756&action=review

Tools/WebGPUShadingLanguageRI/FuncInstantiator.js:99

  •    let resultingFunc = func.visit(new Instantiate());
    
  •    let resultingFunc = func.visit(new Instantiate(substitution));
    

I'll revert.

Tools/WebGPUShadingLanguageRI/InstantiateImmediates.js:44
+

  • visitVariableDecl(node)
  • {
  •    let result = super.visitVariableDecl(node);
    
  •    return result;
    
  • }

I will remove.

@litherum
Copy link
Contributor Author

At 2017-09-03T17:48:12Z, fpizlo@apple.com wrote:
Landed in https://trac.webkit.org/changeset/221550/webkit

@litherum
Copy link
Contributor Author

At 2017-09-27T19:55:25Z, webkit-bug-importer@group.apple.com wrote:
rdar://problem/34694277

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant