-
Notifications
You must be signed in to change notification settings - Fork 14
WSL should have some post-instantiation type checking #176
Comments
At 2017-09-21T16:37:47Z, fpizlo@apple.com wrote: |
At 2017-09-21T17:45:06Z, fpizlo@apple.com wrote: |
At 2017-09-21T17:53:54Z, fpizlo@apple.com wrote: |
At 2017-09-21T21:15:27Z, fpizlo@apple.com wrote: |
At 2017-09-21T21:28:55Z, keith_miller@apple.com wrote: View in context: https://bugs.webkit.org/attachment.cgi?id=321450&action=review r=me with some nits.
I don't understand what this is saying. What is "That"? isPrimitive was/is a property. AFAICT, there is no isPrimitive function?
Nit: you can remove this. Unless you want to be really sure that no arguments are passed to Visitor.
Nit: you could probably move this and the one below out of the switch. |
At 2017-09-21T21:33:03Z, fpizlo@apple.com wrote:
There is an isPrimitive getter all over the place. For example:
Before, this code used its own probably-mostly-correct reimplementation:
That was when this code lived in Checker, so the patch doesn't make this super obvious. I'll fix the changelog to refer to this defunct helper class by name.
Fixed.
Fixed. |
At 2017-09-21T21:36:08Z, fpizlo@apple.com wrote: |
At 2017-09-27T19:23:25Z, webkit-bug-importer@group.apple.com wrote: |
Migrated from https://bugs.webkit.org/show_bug.cgi?id=177303:
At 2017-09-21T15:50:45Z, fpizlo@apple.com wrote:
There are certain things that are easier to check after type instantiation.
Shader type checking is definitely in that category.
The text was updated successfully, but these errors were encountered: