New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

val: copyImageBitmapToTexture should only allow 2d textures #2108

Closed

greggman opened this issue Jan 4, 2023 · 1 comment

Assignees

Contributor

greggman commented Jan 4, 2023 •

edited

looking in CopyExternalTextureToImage.spec.ts there's this comment

Note that we don't need to add tests on the destination texture dimension as currently we require
the destination texture should have RENDER_ATTACHMENT usage, which is only allowed to be used on 2D
textures.

So is this test needed?

The text was updated successfully, but these errors were encountered:

greggman self-assigned this

Collaborator

kainino0x commented Jan 7, 2023

Oh, yeah, someone ran into that while writing other tests. I guess there's nothing we can test here then.

greggman closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment