Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hasura/Postgres type support #195

Open
shyndman opened this issue May 19, 2021 · 8 comments · May be fixed by #205
Open

Hasura/Postgres type support #195

shyndman opened this issue May 19, 2021 · 8 comments · May be fixed by #205
Labels
enhancement New feature or request

Comments

@shyndman
Copy link

shyndman commented May 19, 2021

Hello there,

I'm in the process of writing an adapter library to easily create Ferry clients for connecting to an Nhost.io Hasura backend.

I was thinking that I'd be super useful to have serializers for the Hasura/Postgres types in your library, given its popularity. Something that could easily be included in the user's build.yaml if needed.

Would you consider accepting a contribution?

Related to nhost/nhost-dart#12

@smkhalsa
Copy link
Member

Hi there,

Sure! I'm not sure in which package this would belong. Maybe we can add a ferry_serializers package.

Alternatively, you could publish them in your package and we can just add instructions in our docs for importing them.

@shyndman
Copy link
Author

My feeling is that your users would get a lot more use out of them, and that it would be valuable to have them under the same umbrella.

I don't have any issue continuing to contribute to their upkeep...but I also suspect it'll be a set-and-forget kind of package.

I can also imagine that some of the types would be useful beyond Hasura use — things like iso8601 to DateTime kind of deal.

@smkhalsa
Copy link
Member

Sounds good. Let's add a ferry_serializers package to this repo then.

Let me know if you need anything from me.

@shyndman
Copy link
Author

Will do. Thanks @smkhalsa.

@shyndman
Copy link
Author

shyndman commented Jun 11, 2021

Here's what I'm thinking:

First, I'm going to enumerate the serializers that we need.

Then, I'm going to write a single serializer, and put it up for review. With an example of usage.

You're a lot more familiar with this universe than I am, and I'd love to hear your thoughts. We can tweak as necessary, then I'll dive in fully.

That sound good to you?

@smkhalsa
Copy link
Member

Sure, sounds good

@appinteractive
Copy link

Is this PR solving the issue of JSON field not beeing accessible? @shyndman

@smkhalsa smkhalsa added the enhancement New feature or request label Sep 6, 2021
@wildsurfer
Copy link

Any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants