-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GitHubProjectError
, GitHubProjectUnknownFieldError
, GitHubProjectUnknownFieldOptionError
, GitHubProjectUpdateReadOnlyFieldError
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
changed the title
docs(README):
docs(README): Aug 25, 2023
GitHubProjectError
, GitHubProjectErrorUnknownFieldOption
GitHubProjectError
, GitHubProjectUnknownFieldError
, GitHubProjectUnknownFieldOptionError
, GitHubProjectUpdateReadOnlyFieldError
gr2m
changed the title
docs(README):
feat: Sep 12, 2023
GitHubProjectError
, GitHubProjectUnknownFieldError
, GitHubProjectUnknownFieldOptionError
, GitHubProjectUpdateReadOnlyFieldError
GitHubProjectError
, GitHubProjectUnknownFieldError
, GitHubProjectUnknownFieldOptionError
, GitHubProjectUpdateReadOnlyFieldError
…Error()` to `.toHumanMessage()`
tmelliottjr
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise looks good!
Co-authored-by: Tom Elliott <13594679+tmelliottjr@users.noreply.github.com>
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered preview of new Errors section in the readme.
closes #128
BREAKING CHANGE: When a field could not be found, the message on the thrown error looked like this
it is now
The original message can still be retrieved using
error.toHumanMessage()
BREAKING CHANGE: When a user value cannot be matched with a field option, the message on the thrown error looked like this
it is now
The original message can still be retrieved using
error.toHumanMessage()
BREAKING CHANGE: if a user tried to update a read-only field, the message on the thrown error looked like this
it is now