feat: support iteration fields #95
Conversation
|
I rebased your PR and removed updated fixtures for now. When I run I get an error
Can you check that please? |
|
could you check the failing tests @blombard? Do run a single recorded test you can e.g. do There have been a few changes since, it might be enough to re-record |
|
Hi @gr2m, sorry for letting this fall into limbo. Tests are now successful on my side. 
|
# Conflicts: # test/snapshots/recorded.test.js.snap
| @@ -129,6 +129,28 @@ export function projectFieldsNodesToFieldsMap(state, project, nodes) { | |||
| ); | |||
| } | |||
|
|
|||
| // If the field is of type "Iteration", then the `configuration` property will be set. | |||
| if (node.configuration) { | |||
There was a problem hiding this comment.
I wonder if we maybe should check for node.configuration?.iterations to be truthy? Just in case the .configuration will be used by other fields in future?
|
@all-contributors please add @blombard for code and test |
|
I've put up a pull request to add @blombard! 🎉 |
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Following the issue #94 I created, here is the start of solution.
I'm not used to Typescript so sorry if I make rookie mistakes. :)
Closes #94