Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use graphql to search for existing pull request #105

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Use graphql to search for existing pull request #105

merged 3 commits into from
Sep 6, 2022

Conversation

nqkdev
Copy link
Contributor

@nqkdev nqkdev commented Aug 24, 2022

This PR uses graphql call instead of rest API v3 to get the existing branch and pull request info. This avoids 422 status code for search requests on private/internal repositories.

Discussion on 422 status code more here: https://github.com/orgs/community/discussions/24572

@nqkdev nqkdev marked this pull request as ready for review August 24, 2022 14:32
@gr2m
Copy link
Owner

gr2m commented Aug 24, 2022

Smart! Could you look into updating tests?

@gr2m
Copy link
Owner

gr2m commented Aug 30, 2022

Test coverage dropped below 100%. After running npm test, you can open the coverage report at coverage/lcov-report/index.html

On MacOS/Linux, you can run

npm test && open coverage/lcov-report/index.html

Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@gr2m gr2m merged commit 0c53ab1 into gr2m:main Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

🎉 This PR is included in version 3.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants