fix: avoid creating blobs for UTF-8 text files #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Aug 31, 2023
There was a problem hiding this comment.
any chance you could just remove the blob creation request instead of updating the whole fixture?
How do you know? I'm not aware this is the case |
Experience, I looked for docs on the secondary rate limits but didn't find anything concrete. Others are also unable to find documentation. The secondary limit doesn't appear to be returned in headers, either -- tested with an app and user token :/ |
rmartine-ias
force-pushed
the
utf-8-optim
branch
from
035ac9e
to
b786a32
Compare
5 tasks
gr2m
reviewed
Sep 4, 2023
gr2m
changed the title
gr2m
approved these changes
Sep 4, 2023
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rmartine-ias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To open a pull request using GitHub's API, it's necessary to create a tree, where you can either specify file contents as a string, or the hash of a blob that's already been pushed to GitHub. Creating blobs requires an API call, while specifying file contents does not. GitHub has a low secondary rate limit for creating blobs.
This PR makes it so fewer files are sent as binary blobs. UTF-8 files do not need to be sent up as blobs, they can be included in the tree as their literal contents.
The fixture update is a bit of a mess but I'm not sure if I can do it better.
See also: #121