fix: adapt for latest @octokit/types #66
Conversation
package-lock was the issue
src/compose-create-pull-request.ts
Outdated
| owner, | ||
| repo, | ||
| }); | ||
| const hasFork = forks.data.find( | ||
| (fork) => fork.owner.login === user.data.login | ||
| (fork) => fork!.owner!.login === user.data.login |
There was a problem hiding this comment.
Not sure what the right approach is since if you use fork?.owner?.login code coverage decreases.
There was a problem hiding this comment.
The first exclamation mark is unnecessary. I'm not sure how a fork can get into a state where fork.owner can be null but I guess there is one. I'd change the code above to
| (fork) => fork!.owner!.login === user.data.login | |
| /* istanbul ignore next - fork owner can be null, but we don't test that */ | |
| (fork) => fork.owner?.login === user.data.login |
Alternatively we could add a test for the case when fork.owner is null, but I don't think it's worth it
src/compose-create-pull-request.ts
Outdated
| owner, | ||
| repo, | ||
| }); | ||
| const hasFork = forks.data.find( | ||
| (fork) => fork.owner.login === user.data.login | ||
| (fork) => fork!.owner!.login === user.data.login |
There was a problem hiding this comment.
The first exclamation mark is unnecessary. I'm not sure how a fork can get into a state where fork.owner can be null but I guess there is one. I'd change the code above to
| (fork) => fork!.owner!.login === user.data.login | |
| /* istanbul ignore next - fork owner can be null, but we don't test that */ | |
| (fork) => fork.owner?.login === user.data.login |
Alternatively we could add a test for the case when fork.owner is null, but I don't think it's worth it
src/compose-create-pull-request.ts
Outdated
| owner, | ||
| repo, | ||
| sha: base, | ||
| per_page: 1, | ||
| }); | ||
| state.latestCommitSha = latestCommit.sha; | ||
| state.latestCommitSha = latestCommit.sha as string; |
There was a problem hiding this comment.
Can you update package-lock.json so that @octokit/types 6.3.0+ is used? Then you can remove the as string
| state.latestCommitSha = latestCommit.sha as string; | |
| state.latestCommitSha = latestCommit.sha; |
| import type { Endpoints } from "@octokit/types"; | ||
|
|
||
| export type TreeParameter = Endpoints["POST /repos/:owner/:repo/git/trees"]["parameters"]["tree"]; | ||
| export type TreeParameter = Endpoints["POST /repos/{owner}/{repo}/git/trees"]["parameters"]["tree"]; |
There was a problem hiding this comment.
I think we should add @octokit/types as a direct dependency of this package, as we use it in the code, that will make it more predictable. And I've seen yarn users having problems when using sub-dependencies
|
🎉 This PR is included in version 3.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Selv tak! |
Package-lock had locked
@octokit/typesto version5.x.x...fixes #65