-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod
does not specify a Swift version.
#5
Comments
@lenkaiser I'm unable to reproduce this issue. RxSwift works for me. Can you please share your |
I'm using RxSwift 4.4.0 and if you look in the podspec (https://github.com/CocoaPods/Specs/blob/master/Specs/2/e/c/RxSwift/4.4.0/RxSwift.podspec.json) you can see that this version doesn't include the swift_version parameter yet (5.0.1 does). However this is just one off many pods that require this setting. So if we can think about a solution that works for older dependencies that would be great. MergeFile
|
If you are so excited to implement it and do not have time, check this out for a quick fix. https://github.com/annomusa/cocoapods-pod-merge/pull/1/files |
Maybe we can add the swift version as a parameter to the MergeFile. Another solution would be to add an dictonary with the podname and seift version to the Mergefile. Currently I’m using the latter in my Podfile. This will clean up the Podfile as well |
@annomusa That's one way of doing it ;) This issue is in line with something I plan to implement. We can add a flag like
What do you guys think? |
I think that is good design, putting swift version inside each group really make sense |
Generally speaking this is a good solution but does this impact the optimisation potential of the plugin? If the groups need to be separated due to the swift version how much of a difference would that make in start-up time? For example: 1 group with 10 pods might be better optimised than 2 groups with 5 pods. |
The thing is, it’s anyway not possible to merge pods using different swift versions into one. The pods will fail to compile because some of them expect a different swift version. |
Fair point, didn't take that into consideration this morning. It sounds like combining pods per swift version would be the perfect solution. How much time would it take to implement the feature? |
I'll try to implement it this weekend. |
@lenkaiser, @annomusa I've just released v0.0.3 which adds a new swift_version! flag to manually override the swift version for a merge group. |
A lot of pods give this problem that the 3rd party doesn't specify a Swift version. I get the following error:
Previously I used a small script in the
Podfile
to solve this problem:But I think the plugin gets the pods from the
MergeFile
so we cannot specify a swift version. How could I solve this without forking all pods and adding the swift version to thePodspec
?The text was updated successfully, but these errors were encountered: