Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to change the section about JavaScript #149

Closed
hzoo opened this issue Jun 21, 2017 · 5 comments
Closed

Suggestion to change the section about JavaScript #149

hzoo opened this issue Jun 21, 2017 · 5 comments

Comments

@hzoo
Copy link

hzoo commented Jun 21, 2017

For https://github.com/grab/front-end-guide#new-age-javascript, can you mention using https://github.com/babel/babel-preset-env instead of "ES2015" by which you mean babel-preset-es2015? I would explain that as browsers natively support ES whatever babel can just compile what is necessary.

And regarding babel-preset-stage-0, I would recommend explaining what Stage 0 means if it's going to be mentioned at all (that it's not javascript and just proposals that might go away). If you need help with this, can check out http://babeljs.io/docs/plugins/#presets-stage-x-experimental-presets-, https://github.com/hzoo/role-of-babel-in-js, https://tc39.github.io/process-document/

@yangshun
Copy link
Contributor

Thanks for the suggestions @hzoo . Will get to it immediately.

@sidhuko
Copy link

sidhuko commented Jun 21, 2017

I would recommend suggesting stage-3 for stability. Historically, stage-0 have changed their implementations based on vendor feedback, async/await was a big one, where as a stage-3 is awaiting implementation.

Although you could probably write a codemod to change them nowadays.

@yangshun
Copy link
Contributor

Thanks for your comments @sidhuko , but the fact is that we were using preset-stage-0, and are in the process of changing to preset-env for our apps. I'll add in a note to inform about using stage-3 for stability.

@yangshun yangshun reopened this Jun 21, 2017
@hzoo
Copy link
Author

hzoo commented Jun 21, 2017

Yeah Stage 0 is literally just someone's idea on the committee and could change at any point. Of course we have tests and will try to help migrate users when possible but we are just volunteers.

@yangshun
Copy link
Contributor

Thanks for everyone's comments. Fixed in 4571a88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants