Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace styleable parent name separator from dot to underscore #2

Merged
merged 4 commits into from Jul 30, 2021

Conversation

ajanuar
Copy link
Contributor

@ajanuar ajanuar commented Jul 28, 2021

To handle parent name with dot.

XML:

<declare-styleable name="BaseTheme.AppTheme">
        <attr name="CheckboxDefaultStyle" format="reference"/>
</declare-styleable>

error message:

r-classes/com/albertjanuar/android/arjuna/R.java:7659: error: unexpected token: .
    public static int BaseTheme.AppTheme_CheckboxDefaultStyle = 0;

@arunkumar9t2
Copy link
Contributor

Thanks a lot for fixing this, do you mind adding a small test here?

@arunkumar9t2 arunkumar9t2 self-assigned this Jul 29, 2021
@arunkumar9t2 arunkumar9t2 added the bug Something isn't working label Jul 29, 2021
@ajanuar
Copy link
Contributor Author

ajanuar commented Jul 29, 2021

Sure, will update soon.

@arunkumar9t2
Copy link
Contributor

Thank you, LGTM. Let me know if you have any further changes, if not I can merge this.

@ajanuar
Copy link
Contributor Author

ajanuar commented Jul 30, 2021

Hi Arun, I have no other changes. Thanks!

@akshay-grabtaxi akshay-grabtaxi merged commit 34cb605 into grab:master Jul 30, 2021
@ajanuar ajanuar deleted the styleable-parser-parent branch July 30, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants