Publishing compatibility #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add annotation processor to generate the TestSuite class See merge request mobile/pax-app-core/bazel-common-android!58
Add Bazelrc flags for databinding See merge request mobile/pax-app-core/bazel-common-android!57
… kt_jvm_test targets
Add test macros as the abstraction to generate android_local_test and kt_jvm_test targets See merge request mobile/pax-app-core/bazel-common-android!60
Add associates to android local test macro See merge request mobile/pax-app-core/bazel-common-android!61
…tic generation of per class unit test targets
Introduce `grab_kt_jvm_test` and `grab_android_local_test` for automatic generation of per class unit test targets See merge request mobile/pax-app-core/bazel-common-android!62
Fix `kt_jvm_test` import See merge request mobile/pax-app-core/bazel-common-android!64
Fix Koltin path condition in test macro See merge request mobile/pax-app-core/bazel-common-android!65
… for Android test rule. Update to `kt_jvm_test` instead of `android_local_test`
Update android tools - rebase with Bazel 5.0.0 release See merge request mobile/pax-app-core/bazel-common-android!74
This reverts commit 0d17d47.
…rab#18) * Reorder additional test deps so that the given deps are placed first * Add test to ensure given deps for test are prioritised
Change zipper cfg to exec See merge request mobile/pax-app-core/bazel-common-android!78
…ile resource directly (grab#19)
Pass through tags in kotlin android macro See merge request mobile/pax-app-core/bazel-common-android!79
* Prefix R classes with name to avoid conflicts * Add name to res values file
* Initial work to support non transitive R class with Databinding 7.1.0 * Add configuration option for non transitive R class * Don't pass non transitive R class to stub compiler always
Update `android_tools` for Bazel 6.0 See merge request mobile/pax-app-core/bazel-common-android!80
update parcelize to 1.6.10 (grab#25) See merge request mobile/pax-app-core/bazel-common-android!81
|
Thank you for this! I will verify compatibility internally and get back. |
|
Hi @sugarmanz after verifying internally unfortunately we could not merge this since we need to pass tags for a different optimization internally. We do hope to remove later but no active plans yet. Thank you for trying and submitting this PR. |
akshay-grabtaxi
requested review from
minkuan88,
roscrazy,
arunkumar9t2 and
rifqimfahmi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two relatively small changes that were needed to integrate with our project. Feel free to close this PR if these changes divert from your strategy, but figured I'd contribute back what was necessary for me.
Add JVM resources as parameter to the
kt_db_android_librarymacro and pass to the underlyingkt_jvm_library.Only apply
tagsto the final target to ensure that intermediate targets are bundled properly when capturing the transitive closure.This is a consequence of how the vaticle/bazel-distribution publishing rules capture the transitive closure. If the dependency has a
maven_coordinatestag, then it will be added to the POM, otherwise it will be bundled into the artifact to publish. So, when the tags are applied to the intermediate targets, they won't be properly bundled into the artifact.https://github.com/vaticle/bazel-distribution/blob/a4ff3778d65d6f4c563b70c096d150f7028800ce/maven/rules.bzl#L189-L199