Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical images and videos are cut off when using css and gr.Group #1641

Closed
1 task done
hysts opened this issue Jun 26, 2022 · 1 comment · Fixed by #4896
Closed
1 task done

vertical images and videos are cut off when using css and gr.Group #1641

hysts opened this issue Jun 26, 2022 · 1 comment · Fixed by #4896
Assignees
Labels
bug Something isn't working svelte Frontend-related issue (JS)

Comments

@hysts
Copy link
Collaborator

hysts commented Jun 26, 2022

Describe the bug

When specifying max-width and max-height for images and videos in css, the behavior is inconsistent depending on whether they are in gr.Group or not. It seems when using gr.Group, images and videos are fit to the width, ignoring height.
I don't think they should be cut off when using gr.Group either.

Is there an existing issue for this?

  • I have searched the existing issues

Reproduction

https://huggingface.co/spaces/hysts-debug/gradio-issue-1641

Screenshot

The behavior is the same when the width is longer than height.

But the behavior is not the same when the height is longer than width.

Logs

Running on local URL:  http://localhost:7860/

To create a public link, set `share=True` in `launch()`.

System Info

gradio==3.0.20

Severity

annoying

@hysts hysts added the bug Something isn't working label Jun 26, 2022
@freddyaboulton freddyaboulton added this to the 3.2 milestone Aug 1, 2022
@pngwn pngwn removed their assignment Aug 11, 2022
@abidlabs abidlabs modified the milestones: 3.2, 3.x Aug 18, 2022
@abidlabs abidlabs added the svelte Frontend-related issue (JS) label Jan 19, 2023
@abidlabs
Copy link
Member

Can confirm that this is still an issue in 3.21.0: https://huggingface.co/spaces/abidlabs/gradio-issue-1641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working svelte Frontend-related issue (JS)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants