Download button does not respect the filepath returned by the function

[freddyaboulton]

Describe the bug

In the zip_two_files demo:

import os
from zipfile import ZipFile

import gradio as gr


def zip_two_files(file1, file2):
    with ZipFile("tmp.zip", "w") as zipObj:
        zipObj.write(file1.name, "file1")
        zipObj.write(file2.name, "file2")
    return "tmp.zip"


demo = gr.Interface(
    zip_two_files,
    ["file", "file"],
    "file",
    examples=[
        [os.path.join(os.path.dirname(__file__),"files/titanic.csv"), 
         os.path.join(os.path.dirname(__file__),"files/titanic.csv")],
    ],
)

if __name__ == "__main__":
    demo.launch()

When you download the file, it is renamed download.zip by default on Chrome.

Download version 3.0.22

That's not the case on version 3.0.12. The file is called tmp because that's what the prediction function returns. You can see the same behavior on this space: https://huggingface.co/spaces/radames/dpt-depth-estimation-3d-obj Was this change intentional?

Download version 3.0.12

Is there an existing issue for this?

• I have searched the existing issues

Reproduction

Run the zip_two_files demo on 3.0.22 and download the file.

Screenshot

No response

Logs

-

System Info

3.0.22

Severity

annoying

[AeroDEmi]

Thank you for addressing the bug @freddyaboulton. This came as my output is a mesh file (file.msh) and when I try to download the file it losses the .msh extension.

[freddyaboulton]

Thank you for bringing it to our attention!

[irfan-mekic]

Any updates on this?

[freddyaboulton]

@irfan-mekic Thanks for the follow-up!

We were working on improving the docs the last two weeks. Next we're working on the 3.2 milestone which will focus on bug fixes. I've added this issue to that milestone so someone will take a look at this soon.

[abidlabs]

Reopening as this seems to have come back as a results of #1967