Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design of the error labels have changed and they don't look good #3418

Closed
pngwn opened this issue Mar 8, 2023 · 10 comments · Fixed by #4454
Closed

Design of the error labels have changed and they don't look good #3418

pngwn opened this issue Mar 8, 2023 · 10 comments · Fixed by #4454
Assignees
Labels
bug Something isn't working svelte Frontend-related issue (JS)
Milestone

Comments

@pngwn
Copy link
Member

pngwn commented Mar 8, 2023

Describe the bug

Dark mode change isn't awful, although it is less noticeable. The light mode one doesn't look good at all though.

Before

Screenshot 2023-03-08 at 11 46 16

Screenshot 2023-03-08 at 11 47 11

After
Screenshot 2023-03-08 at 11 41 04
Screenshot 2023-03-08 at 11 41 20

@pngwn pngwn added the bug Something isn't working label Mar 8, 2023
@pngwn
Copy link
Member Author

pngwn commented Mar 8, 2023

cc @aliabid94

@pngwn pngwn added the svelte Frontend-related issue (JS) label Mar 8, 2023
@abidlabs
Copy link
Member

abidlabs commented Mar 8, 2023

Kinda feeling the opposite lol. New light mode looks nice but dark mode looks basic to me. Fine with reverting to original though

@pngwn
Copy link
Member Author

pngwn commented Mar 8, 2023

Light mode looks curved because of the gradient now, which none of the rest of UI does. Dark mode looks clean but isn't as obvious as it used to be.

I didn't really like the old ones though, I'd be happy with some thing else.

@abidlabs
Copy link
Member

abidlabs commented Mar 8, 2023

Light mode looks curved because of the gradient now, which none of the rest of UI does. Dark mode looks clean but isn't as obvious as it used to be.

I see, good point

@aliabid94
Copy link
Collaborator

Hmm ok so I was consolidating CSS variables and I consolidated variables between this and the error modal, so they have the same background. I'd like to keep them the same - would be happy to remove the gradient from both! wdyt?

Screen Shot 2023-03-14 at 8 49 52 PM

@abidlabs
Copy link
Member

Seems reasonable, I agree both the Error message and the Error modal should have the same background. Can we see what the error modal looks like without the gradient?

@abidlabs abidlabs added this to the 3.x milestone Mar 17, 2023
@pngwn
Copy link
Member Author

pngwn commented Mar 20, 2023

I don't think they look particularly visible or error-like. I think the background should be red. The gradient looks very washed out and doesn't really fit imo.

cc @gary149

@hannahblair hannahblair self-assigned this Jun 2, 2023
@hannahblair
Copy link
Collaborator

Here's the error label and modal without the gradient in light and dark mode:

Screenshot 2023-06-08 at 14 31 01 Screenshot 2023-06-08 at 14 30 48

I added a darker red border to the light mode error to correspond with the dark mode border. I think these look better without the gradient imo!

@abidlabs
Copy link
Member

abidlabs commented Jun 8, 2023

They look good, happy to test them out if there's a PR

@gary149
Copy link
Contributor

gary149 commented Jun 8, 2023

I added a darker red border to the light mode error to correspond with the dark mode border. I think these look better without the gradient imo!

LGTM from the screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working svelte Frontend-related issue (JS)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants