Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugs in the audio timeslice #3838

Closed
1 task done
Tracked by #5321
tomchang25 opened this issue Apr 13, 2023 · 3 comments
Closed
1 task done
Tracked by #5321

Minor bugs in the audio timeslice #3838

tomchang25 opened this issue Apr 13, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@tomchang25
Copy link
Contributor

tomchang25 commented Apr 13, 2023

Describe the bug

  1. Audio name changes to "audio" after editing timeslice
  2. Audio timeslice does not reset when clearing and re-uploading audio

As these are just minor bugs and not very urgent. I will fix them over the weekend and create a PR.

Is there an existing issue for this?

  • I have searched the existing issues

Reproduction

  1. Default
    Default
  2. After editing timeslice (name changes to "audio")
    After editing timeslice
  3. Clear and re-upload audio (name remains "1min" and slice not reset)
    2023-04-13 204205

Screenshot

No response

Logs

Not exist

System Info

gradio v3.25.1b2

Severity

annoying

@tomchang25 tomchang25 added the bug Something isn't working label Apr 13, 2023
@abidlabs
Copy link
Member

Thanks @tomchang25!

@abidlabs
Copy link
Member

Hi @tomchang25 would you still be interested in solving these bugs?

@abidlabs
Copy link
Member

abidlabs commented Jan 4, 2024

Both should be fixed now, I believe, thanks to @hannahblair's refactor.

@abidlabs abidlabs closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants