Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nits on the Getting Started page #5778

Closed
1 task done
freddyaboulton opened this issue Oct 3, 2023 · 7 comments · Fixed by #6767
Closed
1 task done

Nits on the Getting Started page #5778

freddyaboulton opened this issue Oct 3, 2023 · 7 comments · Fixed by #6767
Assignees
Labels
docs/website Related to documentation or website good first issue Good for newcomers

Comments

@freddyaboulton
Copy link
Collaborator

freddyaboulton commented Oct 3, 2023

  • I have searched to see if a similar issue already exists.

There are too many separate concepts in the "Sharing Your App" section of the getting started guide.

image

My Recommendation:

  • Mounting within another... should be under the Sharing Your App Header
  • Pull Authentication into another section and include Password Protected... and OAuth into that section
  • Accessing the Network Request feels pretty random here. Maybe move to Key Features?
  • Security should pulled out into its own section.
  • Api Usage should be pulled out into its own section.
@abidlabs abidlabs added the docs/website Related to documentation or website label Oct 3, 2023
@reginareynolds
Copy link
Contributor

I can take this one.

@abidlabs
Copy link
Member

abidlabs commented Oct 5, 2023

Thanks that'd be great @reginareynolds, looking forward to your PR!

@reginareynolds
Copy link
Contributor

This is going to sound like a silly question, but where did the website folder go? According to the Contributing document, it's supposed to be in the root directory, but it's not. Did it get moved to the _website folder in the js directory?

@abidlabs
Copy link
Member

abidlabs commented Oct 5, 2023

Hi @reginareynolds oh wow good catch! Yes, the website is now located at /js/_website. Would you like to open a PR to fix our contributing guide first?

Thanks so much!

@Luwa-Tech
Copy link

Hi @abidlabs is this issue still open.

@freddyaboulton
Copy link
Collaborator Author

Yea @Luwa-Tech ! If you'd like to open a PR, please feel free

@debrupf2946
Copy link

@freddyaboulton I want to work on the issue, I will be opening a PR by today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/website Related to documentation or website good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants