Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the code related to root and root_url #5830

Closed
abidlabs opened this issue Oct 6, 2023 · 5 comments · Fixed by #6159
Closed

Clean up the code related to root and root_url #5830

abidlabs opened this issue Oct 6, 2023 · 5 comments · Fixed by #6159
Assignees
Labels
refactor Involves refactoring existing code
Milestone

Comments

@abidlabs
Copy link
Member

abidlabs commented Oct 6, 2023

All the code to resolve URL paths correctly with root and root_url has gotten quite messy.

It would be good to clean this up. In particular, now that replicas use subdirectories instead of subdomains, we can revert most of the changes we made in PRs #5776 and instead just use the same logic we use for the regular fastapi root path.

For clarity, we should also rename root_url to remote_url or something.

@abidlabs abidlabs added the refactor Involves refactoring existing code label Oct 6, 2023
@HeetVekariya
Copy link

I would like to work on this issue.
As i am new to this repo, can you please locate the files that is to be refactored ?

@abidlabs
Copy link
Member Author

abidlabs commented Oct 6, 2023

Hi @HeetVekariya this isn't an issue I'd suggest if you are new to the repo, as there is some internal discussion and context that is important. Instead, I'd suggest picking one of the issues from this list: https://github.com/gradio-app/gradio/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@abidlabs abidlabs added this to the 4.0 milestone Oct 7, 2023
@abidlabs
Copy link
Member Author

Let's rename root_url to _remote_url to designate it as an internal parameter in the component classes

@abidlabs
Copy link
Member Author

Also see this internal discussion

@abidlabs
Copy link
Member Author

Closed on v4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Involves refactoring existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants