Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing download button for gr.components.Audio #7088

Closed
1 task done
ngaudemet opened this issue Jan 20, 2024 · 6 comments · Fixed by #7104
Closed
1 task done

missing download button for gr.components.Audio #7088

ngaudemet opened this issue Jan 20, 2024 · 6 comments · Fixed by #7104
Assignees
Labels
enhancement New feature or request

Comments

@ngaudemet
Copy link

Describe the bug

their should be a download button in my Audio component
but I can't see it anywhere, neither on Safari or Chrome, neither when I upload a mp3 nor when I record from my microphone.
it is important that users are able to download their mic recording.
my version of gradio is 4.12.0

the PR "Add download button for audio #4977" should have solved this but it seems it doesn't work.

Have you searched existing issues? 🔎

  • I have searched and found no existing issues

Reproduction

audio = gr.components.Audio(
label="Upload an audio"
type="filepath",
visible=True,
interactive=True,
show_download_button=True,
)

Screenshot

image

Logs

No response

System Info

Successfully installed gradio-4.12.0 gradio-client-0.8.0

Severity

I can work around it

@ngaudemet ngaudemet added the bug Something isn't working label Jan 20, 2024
@abidlabs
Copy link
Member

It seems like there may have been a regression here, cc @hannahblair?

@abidlabs abidlabs added the Regression Bugs did not exist in previous versions of Gradio label Jan 21, 2024
@hannahblair
Copy link
Collaborator

hannahblair commented Jan 21, 2024

@abidlabs This isn't a regression - the download button only shows for static image components. I think this is the case for a couple other components e.g. ImageEditor, Video. We should change this - either by allowing interactive components to have a download button or documenting this better. WDYT?

@abidlabs abidlabs removed the Regression Bugs did not exist in previous versions of Gradio label Jan 21, 2024
@abidlabs
Copy link
Member

Ah thanks for clarifying @hannahblair. Is it feasible to add the download button to the interactive Audio component? I think its useful as in some cases, an interactive Audio component may serve as both an input and an output, and so it would make sense for a user to be able to download the audio even if interactive=True

@abidlabs abidlabs added enhancement New feature or request and removed bug Something isn't working labels Jan 21, 2024
@hannahblair
Copy link
Collaborator

hannahblair commented Jan 21, 2024

@abidlabs I'd agree! It's feasible. Shall we add this to the other components for consistency?

@abidlabs
Copy link
Member

Let's do it

@ngaudemet
Copy link
Author

thanks a lot. it is also useful when a user records an audio with their mic, and simply wants to download the audio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants