Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

using gr.LogoutButton breaks app #7695

Closed
1 task done
xianbaoqian opened this issue Mar 14, 2024 · 4 comments 路 Fixed by #7697
Closed
1 task done

using gr.LogoutButton breaks app #7695

xianbaoqian opened this issue Mar 14, 2024 · 4 comments 路 Fixed by #7697
Labels
bug Something isn't working docs/website Related to documentation or website pending clarification

Comments

@xianbaoqian
Copy link

Describe the bug

https://www.gradio.app/guides/sharing-your-app#o-auth-login-via-hugging-face needs to be updated

Copy & pasting the code causes an error after the app is started.

Have you searched existing issues? 馃攷

  • I have searched and found no existing issues

Reproduction

import gradio as gr

Screenshot

image

Logs

No response

System Info

default gradio version on HF space

Severity

I can work around it

@xianbaoqian xianbaoqian added the bug Something isn't working label Mar 14, 2024
@pngwn pngwn added the docs/website Related to documentation or website label Mar 14, 2024
@pngwn pngwn changed the title Doc OAuth guide is using deprecated gr.LogoutButton Mar 14, 2024
@pngwn
Copy link
Member

pngwn commented Mar 14, 2024

This is a deprecation so shouldn't break anything.

@Wauplin When we unified the login and logout button, did we break the previous behaviour?

@pngwn pngwn changed the title OAuth guide is using deprecated gr.LogoutButton using gr.LogoutButton breaks app Mar 14, 2024
@pngwn
Copy link
Member

pngwn commented Mar 14, 2024

Relevant PR: #7063

@Wauplin
Copy link
Contributor

Wauplin commented Mar 14, 2024

Thanks for the ping @pngwn. gr.LogoutButton is indeed deprecated but that's not the problem here (it raises a UserWarning but that's all). The snippet in the docs is missing the demo.launch() line, that's why no errors is raised in the logs (+ also a huggingface_hub import). I opened #7697 to fix this.

I also realized OAuth is currently broken in the latest version of gradio. Fixed that too in the PR (more details there).

@pngwn
Copy link
Member

pngwn commented Mar 14, 2024

Ah, thanks for clarifying @Wauplin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs/website Related to documentation or website pending clarification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants