Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubbles in Chatbot should not be clickable #8163

Open
1 task done
letmaik opened this issue Apr 29, 2024 · 2 comments
Open
1 task done

Bubbles in Chatbot should not be clickable #8163

letmaik opened this issue Apr 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@letmaik
Copy link

letmaik commented Apr 29, 2024

  • I have searched to see if a similar issue already exists.

<button> is used for chat bubbles which makes the mouse cursor appear as a pointer. This is quite confusing as users often like to select parts of the response and for that there should be no pointer mouse cursor.

See

<button
data-testid={j == 0 ? "user" : "bot"}
class:latest={i === value.length - 1}
class:message-markdown-disabled={!render_markdown}
style:user-select="text"
class:selectable
style:text-align={rtl ? "right" : "left"}
on:click={() => handle_select(i, j, message)}
on:keydown={(e) => {
if (e.key === "Enter") {
handle_select(i, j, message);
}
}}
dir={rtl ? "rtl" : "ltr"}
aria-label={(j == 0 ? "user" : "bot") +
"'s message: " +
(typeof message === "string"
? message
: `a file of type ${message.file?.mime_type}, ${
message.file?.alt_text ??
message.file?.orig_name ??
""
}`)}
>

@abidlabs
Copy link
Member

cc @dawoodkhan82 @hannahblair

@abidlabs abidlabs added the bug Something isn't working label Apr 29, 2024
@hannahblair
Copy link
Collaborator

Hmm, this was intentional as an accessibility improvement due to the interactive nature of the chat bubbles when click events are enabled. That said, it's understandable that the cursor can cause confusion. To fix this we can explicitly set the cursor to text, and ensure the aria labelling is clear. Should be a quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants