Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Components] Option for build target #8416

Closed
radames opened this issue May 30, 2024 · 2 comments · Fixed by #8520
Closed

[Custom Components] Option for build target #8416

radames opened this issue May 30, 2024 · 2 comments · Fixed by #8520
Assignees
Labels
custom-components Related to custom component cli or workflow enhancement New feature or request

Comments

@radames
Copy link
Contributor

radames commented May 30, 2024

Sorry if there is already an open issue for this, but here's a reminder to add the target: 'esnext' option when building custom components.

cc @pngwn

The currently workaround is do edit node_modules

go into your node modules/gradio/preview/dist/index.js
go into line ~278
add this in the build object: target: 'esnext',
then `gradio cc build ` again
@pngwn
Copy link
Member

pngwn commented May 31, 2024

Thanks for this @radames, it did indeed slip my mind.

@pngwn pngwn self-assigned this May 31, 2024
@abidlabs abidlabs added the enhancement New feature or request label Jun 1, 2024
@freddyaboulton freddyaboulton added the custom-components Related to custom component cli or workflow label Jun 3, 2024
@freddyaboulton
Copy link
Collaborator

+1 just ran into this myself for the pdf component when trying to upgrade pdf.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom-components Related to custom component cli or workflow enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants