Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI #142

Merged
merged 8 commits into from
Nov 27, 2021
Merged

Refactor CI #142

merged 8 commits into from
Nov 27, 2021

Conversation

aniketmaurya
Copy link
Owner

@aniketmaurya aniketmaurya commented Nov 26, 2021

Changes

Fixes # (issue)

Type of change

  • Documentation Update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #142 (69c1213) into master (948eda6) will increase coverage by 0.22%.
The diff coverage is 72.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   78.85%   79.08%   +0.22%     
==========================================
  Files          53       53              
  Lines        1485     1501      +16     
==========================================
+ Hits         1171     1187      +16     
  Misses        314      314              
Flag Coverage Δ
unittests 79.08% <72.97%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chitra/datagenerator.py 47.94% <0.00%> (ø)
chitra/dataloader.py 45.26% <0.00%> (+0.58%) ⬆️
chitra/image/image.py 86.11% <0.00%> (+0.39%) ⬆️
chitra/image/tf_image.py 84.61% <0.00%> (ø)
chitra/serve/cloud/aws_serverless.py 74.28% <0.00%> (+0.75%) ⬆️
chitra/utility/tf_utils.py 60.60% <0.00%> (ø)
chitra/coordinates.py 79.68% <66.66%> (+0.99%) ⬆️
chitra/trainer.py 51.96% <75.00%> (+0.47%) ⬆️
chitra/constants.py 100.00% <100.00%> (ø)
chitra/core.py 91.30% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 948eda6...69c1213. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot added documentation Improvements or additions to documentation test add/update tests labels Nov 27, 2021
@pep8speaks
Copy link

pep8speaks commented Nov 27, 2021

Hello @aniketmaurya! Thanks for updating this PR.

Line 3:101: E501 line too long (101 > 100 characters)

Line 104:101: E501 line too long (115 > 100 characters)

Line 23:101: E501 line too long (105 > 100 characters)
Line 156:101: E501 line too long (110 > 100 characters)

Line 153:101: E501 line too long (114 > 100 characters)

Line 4:101: E501 line too long (114 > 100 characters)
Line 10:101: E501 line too long (109 > 100 characters)

Line 70:101: E501 line too long (102 > 100 characters)

Line 38:101: E501 line too long (109 > 100 characters)
Line 44:101: E501 line too long (101 > 100 characters)

Line 24:101: E501 line too long (111 > 100 characters)

Line 8:101: E501 line too long (119 > 100 characters)

Line 162:101: E501 line too long (120 > 100 characters)
Line 177:101: E501 line too long (107 > 100 characters)

Line 16:101: E501 line too long (102 > 100 characters)

Line 14:101: E501 line too long (118 > 100 characters)

Line 9:101: E501 line too long (101 > 100 characters)

Line 8:101: E501 line too long (111 > 100 characters)

Line 17:101: E501 line too long (118 > 100 characters)

Comment last updated at 2021-11-27 17:13:52 UTC

@aniketmaurya aniketmaurya self-assigned this Nov 27, 2021
@aniketmaurya aniketmaurya enabled auto-merge (squash) November 27, 2021 17:19
@aniketmaurya aniketmaurya merged commit 3b15b39 into master Nov 27, 2021
@aniketmaurya aniketmaurya deleted the refactor_ci branch November 27, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test add/update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants