Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add batchify #147

Merged
merged 5 commits into from
Dec 22, 2021
Merged

add batchify #147

merged 5 commits into from
Dec 22, 2021

Conversation

aniketmaurya
Copy link
Owner

@aniketmaurya aniketmaurya commented Dec 22, 2021

Changes

Fixes # (issue)

Type of change

  • Documentation Update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@pep8speaks
Copy link

pep8speaks commented Dec 22, 2021

Hello @aniketmaurya! Thanks for updating this PR.

Line 44:28: E203 whitespace before ':'

Comment last updated at 2021-12-22 13:16:48 UTC

@github-actions github-actions bot added the test add/update tests label Dec 22, 2021
@aniketmaurya aniketmaurya self-assigned this Dec 22, 2021
@aniketmaurya aniketmaurya added the enhancement New feature or request label Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #147 (8cbae4f) into master (9f73177) will increase coverage by 0.09%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   79.12%   79.22%   +0.09%     
==========================================
  Files          55       55              
  Lines        1504     1516      +12     
==========================================
+ Hits         1190     1201      +11     
- Misses        314      315       +1     
Flag Coverage Δ
unittests 79.22% <92.85%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chitra/data_processing/processor.py 96.87% <88.88%> (-3.13%) ⬇️
chitra/data_processing/__init__.py 100.00% <100.00%> (ø)
tests/data_processing/test_processor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f73177...8cbae4f. Read the comment docs.

@aniketmaurya aniketmaurya merged commit 6290c9d into master Dec 22, 2021
@aniketmaurya aniketmaurya deleted the feature/batchify branch December 22, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test add/update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants