Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #154

Merged
merged 5 commits into from
Jan 3, 2022
Merged

fixes #154

merged 5 commits into from
Jan 3, 2022

Conversation

aniketmaurya
Copy link
Owner

Changes

Fixes # (issue)

Type of change

  • Documentation Update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@aniketmaurya aniketmaurya self-assigned this Jan 3, 2022
@aniketmaurya aniketmaurya added the bug Something isn't working label Jan 3, 2022
@github-actions github-actions bot added the test add/update tests label Jan 3, 2022
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #154 (602fabe) into master (9a0377a) will increase coverage by 0.12%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   79.18%   79.30%   +0.12%     
==========================================
  Files          55       55              
  Lines        1518     1522       +4     
==========================================
+ Hits         1202     1207       +5     
+ Misses        316      315       -1     
Flag Coverage Δ
unittests 79.30% <84.61%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chitra/dataloader.py 48.51% <81.81%> (+3.15%) ⬆️
tests/test_dataloader.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0377a...602fabe. Read the comment docs.

@aniketmaurya aniketmaurya merged commit 53840ea into master Jan 3, 2022
@aniketmaurya aniketmaurya deleted the fixes branch January 3, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test add/update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant