Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Autotask feature #54

Merged
merged 9 commits into from
Sep 4, 2021
Merged

Adding Autotask feature #54

merged 9 commits into from
Sep 4, 2021

Conversation

gagan3012
Copy link
Contributor

Changes

Fixes #41 (issue)

Type of change

  • 🔬 New feature (non-breaking change which adds functionality)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

Copy link
Contributor

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😀

Could you fix the tests?

@aniketmaurya aniketmaurya added the enhancement New feature or request label Sep 4, 2021
@aniketmaurya aniketmaurya added this to the 0.0.5 milestone Sep 4, 2021
@github-actions github-actions bot added the test label Sep 4, 2021
@aniketmaurya aniketmaurya enabled auto-merge (squash) September 4, 2021 02:37
auto-merge was automatically disabled September 4, 2021 02:40

Head branch was pushed to by a user without write access

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #54 (9b2f372) into main (230b13c) will decrease coverage by 0.18%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   98.57%   98.38%   -0.19%     
==========================================
  Files          17       19       +2     
  Lines         280      309      +29     
==========================================
+ Hits          276      304      +28     
- Misses          4        5       +1     
Flag Coverage Δ
unittests 98.38% <96.55%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gradsflow/autotasks/autotasks.py 90.90% <90.90%> (ø)
gradsflow/autotasks/__init__.py 100.00% <100.00%> (ø)
tests/tasks/test_auto.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230b13c...9b2f372. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aniketmaurya aniketmaurya enabled auto-merge (squash) September 4, 2021 03:17
@aniketmaurya aniketmaurya merged commit 4e0c40a into gradsflow:main Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic Task Selection
2 participants