Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💜 integrate torchmetrics #80

Merged
merged 7 commits into from Oct 1, 2021
Merged

💜 integrate torchmetrics #80

merged 7 commits into from Oct 1, 2021

Conversation

aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Oct 1, 2021

Changes

Fixes #79

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #80 (a039ad3) into main (98632ae) will decrease coverage by 0.40%.
The diff coverage is 92.47%.

❗ Current head a039ad3 differs from pull request most recent head 58d0a76. Consider uploading reports for the commit 58d0a76 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   95.10%   94.69%   -0.41%     
==========================================
  Files          45       45              
  Lines        1082     1131      +49     
==========================================
+ Hits         1029     1071      +42     
- Misses         53       60       +7     
Flag Coverage Δ
unittests 94.69% <92.47%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gradsflow/models/tracker.py 86.66% <71.42%> (-13.34%) ⬇️
gradsflow/models/base.py 87.34% <87.50%> (-0.16%) ⬇️
tests/models/test_model.py 97.29% <92.85%> (-2.71%) ⬇️
gradsflow/callbacks/progress.py 95.65% <100.00%> (-0.43%) ⬇️
gradsflow/callbacks/runner.py 94.73% <100.00%> (+0.09%) ⬆️
gradsflow/core/base.py 100.00% <100.00%> (ø)
gradsflow/data/image.py 96.87% <100.00%> (ø)
gradsflow/models/model.py 96.52% <100.00%> (+0.29%) ⬆️
gradsflow/models/utils.py 100.00% <100.00%> (ø)
gradsflow/utility/common.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98632ae...58d0a76. Read the comment docs.

@github-actions github-actions bot added the test label Oct 1, 2021
@aniketmaurya aniketmaurya changed the title integrate torchmetrics 💜 integrate torchmetrics Oct 1, 2021
@aniketmaurya aniketmaurya added the enhancement New feature or request label Oct 1, 2021
@aniketmaurya aniketmaurya added this to the 0.0.6 milestone Oct 1, 2021
@aniketmaurya aniketmaurya merged commit 4e5fe7c into main Oct 1, 2021
@aniketmaurya aniketmaurya deleted the feature/torchmetrics branch October 1, 2021 18:10
@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request example test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrate torchmetrics
1 participant