Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for hardcoded dashboard uid #1027

Merged
merged 8 commits into from May 2, 2023
Merged

feat: add support for hardcoded dashboard uid #1027

merged 8 commits into from May 2, 2023

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented May 1, 2023 •
edited

Changes:

  • Previously, a dashboard would be fetched once per grafana instance. Now, it's fetched once for all instances;
  • Hardcoded dashboard uids are now preserved;
  • When there's a change in dashboard uid, a dashboard with an old uid will get deleted and then recreated with a new uid.

Fixes: #982

@weisdd weisdd added the enhancement New feature or request label May 1, 2023
@weisdd weisdd requested review from pb82, NissesSenap and HVBE May 1, 2023 08:42
@weisdd weisdd self-assigned this May 1, 2023
@weisdd weisdd mentioned this pull request May 1, 2023
Closed
@weisdd weisdd mentioned this pull request May 1, 2023
Closed
@NissesSenap NissesSenap merged commit 8ec3fa0 into master May 2, 2023
9 checks passed
@NissesSenap NissesSenap deleted the feat/custom-uid branch May 2, 2023 11:54
@hwu-talendbj hwu-talendbj mentioned this pull request May 6, 2023
Closed
@redminion0 redminion0 mentioned this pull request May 10, 2023
Closed
@weisdd weisdd mentioned this pull request May 14, 2023
Merged
@weisdd weisdd mentioned this pull request Jun 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pb82 pb82 pb82 approved these changes

@HVBE HVBE HVBE approved these changes

@NissesSenap NissesSenap Awaiting requested review from NissesSenap NissesSenap is a code owner

Assignees

@weisdd weisdd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Links are broken because of UID overwriting
4 participants
@weisdd @pb82 @HVBE @NissesSenap