Remove rbac proxy #1030
Merged
Remove rbac proxy #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NissesSenap
reviewed
May 2, 2023
| port: 8443 | ||
| protocol: TCP | ||
| targetPort: https | ||
| - name: metrics |
There was a problem hiding this comment.
I added a new metrics service for the bundle.
| @@ -24,6 +24,10 @@ bases: | |||
| # [PROMETHEUS] To enable prometheus monitor, uncomment all sections with 'PROMETHEUS'. | |||
| #- ../prometheus | |||
|
|
|||
| resources: | |||
There was a problem hiding this comment.
Adding it as a resource
| @@ -25,36 +25,42 @@ spec: | |||
| securityContext: | |||
| runAsNonRoot: true | |||
| containers: | |||
| - args: | |||
There was a problem hiding this comment.
Indentation, please ignore
config/manager/manager.yaml
Outdated
Comment on lines
29
to
30
| - --health-probe-bind-address=:8081 | ||
| - --metrics-bind-address=127.0.0.1:9090 |
There was a problem hiding this comment.
Added the port binding directly to manager.yaml
There was a problem hiding this comment.
will 127.0.0.1 not make the metrics only available to the pod itself but not externally?
| imagePullPolicy: Always | ||
| securityContext: | ||
| allowPrivilegeEscalation: false | ||
| ports: |
|
Thanks @NissesSenap I'll verify the metrics access and then get this merged. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1017 and #1020