Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect uid in dashboard exists method #1051

Merged
merged 1 commit into from May 14, 2023
Merged

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented May 14, 2023

In #1027, dashboard exists method was not updated to use correct uid. As a result, the operator will never stop reconciling dashboards with hardcoded uids creating a loop:

  • the operator creates a dashboard and updates CR status with correct uid;
  • since CR is updated, the operator receives an update via WATCH. That's where it was supposed to stop by checking that dashboard exists, hash is the same, and periodic resync timeout hasn't elapsed. Though, since uid is taken from CR instead of the dashboard, the operator would think the dashboard does not yet exist in grafana, so it reuploads it and updates lastResync in CR status;
  • CR status update triggers another reconciliation, and so on.

Fixes: #1045

@weisdd weisdd merged commit 6aadee6 into master May 14, 2023
9 checks passed
@weisdd weisdd deleted the fix/dashboard-exists branch May 14, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Dashboards constantly refreshing in operator
2 participants