fix: incorrect uid in dashboard exists method #1051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1027, dashboard exists method was not updated to use correct uid. As a result, the operator will never stop reconciling dashboards with hardcoded uids creating a loop:
uid
is taken from CR instead of the dashboard, the operator would think the dashboard does not yet exist in grafana, so it reuploads it and updateslastResync
in CR status;Fixes: #1045