feat: add support for raw folder permissions #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NissesSenap
approved these changes
May 16, 2023
| permissions := grapi.PermissionItems{} | ||
| err = json.Unmarshal([]byte(cr.Spec.Permissions), &permissions) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to unmarshal spec.permissions: %w", err) |
There was a problem hiding this comment.
We have an issue for dashboards around if we get an error for the specific dashboard it would be nice if we make this visible in the status as well.
Should we do that for folders also?
Might be a little painful since we have to consider multiple instances.
But for a json error like this it should be easy.
pb82
approved these changes
May 17, 2023
|
@NissesSenap yeah, I agree with your suggestion, let's add it in one of the next PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for raw folder permissions (JSON).
If we ever add support for teams, we can implement something more complex.