Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extended status for kubectl #1058

Merged
merged 4 commits into from May 22, 2023
Merged

feat: extended status for kubectl #1058

merged 4 commits into from May 22, 2023

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented May 18, 2023

This is a tiny change that adds some additional fields to kubectl outputs. Partially inspired by #999.

grafana

$ k get grafana
NAME      STAGE      STAGE STATUS   AGE
grafana   complete   success        2d14h

dashboard

$ k get grafanadashboard
NAME                      NO MATCHING INSTANCES   LAST RESYNC   AGE
grafanadashboard-sample   true                    3s            66m

$ k get grafanadashboard
NAME                      NO MATCHING INSTANCES   LAST RESYNC   AGE
grafanadashboard-sample                           15s           60m

folder

$ k get grafanafolder
NAME          NO MATCHING INSTANCES   AGE
test-folder                           2d14h

$ k get grafanafolder
NAME          NO MATCHING INSTANCES   AGE
test-folder   true                    2d14h

datasource

$ k get grafanadatasource
NAME                        NO MATCHING INSTANCES   AGE
grafanadatasource-sample1   true                    3m
grafanadatasource-sample2                           3m

@weisdd weisdd requested review from pb82, NissesSenap and HVBE May 18, 2023 11:38
@weisdd weisdd self-assigned this May 18, 2023
@pb82
Copy link
Collaborator

pb82 commented May 19, 2023

thanks @weisdd this looks good! I'll give it a try and then approve.

Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally, works nicely! 👍

@HVBE HVBE merged commit 2332f33 into master May 22, 2023
9 checks passed
@HVBE HVBE deleted the feat/extended-status branch May 22, 2023 19:31
smuda pushed a commit to smuda/grafana-operator that referenced this pull request May 31, 2023
Co-authored-by: Peter Braun <pbraun@redhat.com>
Co-authored-by: Edvin N <edvin.norling@gmail.com>
Co-authored-by: Hubert Stefanski <35736504+HubertStefanski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants