Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment reconciler): Couldn't parse image reference "docker.io/grafana/grafana@9.1.6" #1320

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

sonnyg
Copy link
Contributor

@sonnyg sonnyg commented Nov 28, 2023

To Reproduce

  1. Perform a basic helm deployment (flux in my case) of the grafana-operater.
  2. Create a sample Grafana and GrafanaDashboard resource.

Result

The resultant Deployment artifact produces the following error:

Warning  InspectFailed  9s (x11 over 2m7s)  kubelet            Failed to apply default image tag "docker.io/grafana/grafana@9.1.6": couldn't parse image reference "docker.io/grafana/grafana@9.1.6": invalid reference format
Warning  Failed         9s (x11 over 2m7s)  kubelet            Error: InvalidImageName

After some checking, I found the cause related to a recent change made to the deployment_reconciler.go file. The issue seemed straightforward enough, so I made the fix and added some tests.

I have never done go before, so please accept my apologies if I made any mistakes.

Thank you for your consideration and review.

@NissesSenap
Copy link
Collaborator

Thanks allot @sonnyg , we apparently didn't do a very good job in verifying the last major change.
I will merge your PR directly and cut a new release.

@NissesSenap NissesSenap merged commit 9261965 into grafana:master Nov 28, 2023
9 checks passed
@sonnyg
Copy link
Contributor Author

sonnyg commented Nov 28, 2023

You are very welcome @NissesSenap . I am very thankful for this project and I'm glad I was able to help out!

@sonnyg sonnyg deleted the fix/grafana-image-tag branch November 28, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants